| 1 | //==- NonnullGlobalConstantsChecker.cpp ---------------------------*- C++ -*--// |
| 2 | // |
| 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
| 6 | // |
| 7 | //===----------------------------------------------------------------------===// |
| 8 | // |
| 9 | // This checker adds an assumption that constant globals of certain types* are |
| 10 | // non-null, as otherwise they generally do not convey any useful information. |
| 11 | // The assumption is useful, as many framework use e. g. global const strings, |
| 12 | // and the analyzer might not be able to infer the global value if the |
| 13 | // definition is in a separate translation unit. |
| 14 | // The following types (and their typedef aliases) are considered to be |
| 15 | // non-null: |
| 16 | // - `char* const` |
| 17 | // - `const CFStringRef` from CoreFoundation |
| 18 | // - `NSString* const` from Foundation |
| 19 | // - `CFBooleanRef` from Foundation |
| 20 | // |
| 21 | //===----------------------------------------------------------------------===// |
| 22 | |
| 23 | #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" |
| 24 | #include "clang/StaticAnalyzer/Core/Checker.h" |
| 25 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 26 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
| 27 | #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h" |
| 28 | #include <optional> |
| 29 | |
| 30 | using namespace clang; |
| 31 | using namespace ento; |
| 32 | |
| 33 | namespace { |
| 34 | |
| 35 | class NonnullGlobalConstantsChecker : public Checker<check::Location> { |
| 36 | mutable IdentifierInfo *NSStringII = nullptr; |
| 37 | mutable IdentifierInfo *CFStringRefII = nullptr; |
| 38 | mutable IdentifierInfo *CFBooleanRefII = nullptr; |
| 39 | mutable IdentifierInfo *CFNullRefII = nullptr; |
| 40 | |
| 41 | public: |
| 42 | NonnullGlobalConstantsChecker() {} |
| 43 | |
| 44 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 45 | CheckerContext &C) const; |
| 46 | |
| 47 | private: |
| 48 | void initIdentifierInfo(ASTContext &Ctx) const; |
| 49 | |
| 50 | bool isGlobalConstString(SVal V) const; |
| 51 | |
| 52 | bool isNonnullType(QualType Ty) const; |
| 53 | }; |
| 54 | |
| 55 | } // namespace |
| 56 | |
| 57 | /// Lazily initialize cache for required identifier information. |
| 58 | void NonnullGlobalConstantsChecker::initIdentifierInfo(ASTContext &Ctx) const { |
| 59 | if (NSStringII) |
| 60 | return; |
| 61 | |
| 62 | NSStringII = &Ctx.Idents.get(Name: "NSString" ); |
| 63 | CFStringRefII = &Ctx.Idents.get(Name: "CFStringRef" ); |
| 64 | CFBooleanRefII = &Ctx.Idents.get(Name: "CFBooleanRef" ); |
| 65 | CFNullRefII = &Ctx.Idents.get(Name: "CFNullRef" ); |
| 66 | } |
| 67 | |
| 68 | /// Add an assumption that const string-like globals are non-null. |
| 69 | void NonnullGlobalConstantsChecker::checkLocation(SVal location, bool isLoad, |
| 70 | const Stmt *S, |
| 71 | CheckerContext &C) const { |
| 72 | initIdentifierInfo(Ctx&: C.getASTContext()); |
| 73 | if (!isLoad || !location.isValid()) |
| 74 | return; |
| 75 | |
| 76 | ProgramStateRef State = C.getState(); |
| 77 | |
| 78 | if (isGlobalConstString(V: location)) { |
| 79 | SVal V = State->getSVal(LV: location.castAs<Loc>()); |
| 80 | std::optional<DefinedOrUnknownSVal> Constr = |
| 81 | V.getAs<DefinedOrUnknownSVal>(); |
| 82 | |
| 83 | if (Constr) { |
| 84 | |
| 85 | // Assume that the variable is non-null. |
| 86 | ProgramStateRef OutputState = State->assume(Cond: *Constr, Assumption: true); |
| 87 | C.addTransition(State: OutputState); |
| 88 | } |
| 89 | } |
| 90 | } |
| 91 | |
| 92 | /// \param V loaded lvalue. |
| 93 | /// \return whether @c val is a string-like const global. |
| 94 | bool NonnullGlobalConstantsChecker::isGlobalConstString(SVal V) const { |
| 95 | std::optional<loc::MemRegionVal> RegionVal = V.getAs<loc::MemRegionVal>(); |
| 96 | if (!RegionVal) |
| 97 | return false; |
| 98 | auto *Region = dyn_cast<VarRegion>(Val: RegionVal->getAsRegion()); |
| 99 | if (!Region) |
| 100 | return false; |
| 101 | const VarDecl *Decl = Region->getDecl(); |
| 102 | |
| 103 | if (!Decl->hasGlobalStorage()) |
| 104 | return false; |
| 105 | |
| 106 | QualType Ty = Decl->getType(); |
| 107 | bool HasConst = Ty.isConstQualified(); |
| 108 | if (isNonnullType(Ty) && HasConst) |
| 109 | return true; |
| 110 | |
| 111 | // Look through the typedefs. |
| 112 | while (const Type *T = Ty.getTypePtr()) { |
| 113 | if (const auto *AT = dyn_cast<AttributedType>(Val: T)) { |
| 114 | if (AT->getAttrKind() == attr::TypeNonNull) |
| 115 | return true; |
| 116 | Ty = AT->getModifiedType(); |
| 117 | } else if (const auto *ET = dyn_cast<ElaboratedType>(Val: T)) { |
| 118 | const auto *TT = dyn_cast<TypedefType>(Val: ET->getNamedType()); |
| 119 | if (!TT) |
| 120 | return false; |
| 121 | Ty = TT->getDecl()->getUnderlyingType(); |
| 122 | // It is sufficient for any intermediate typedef |
| 123 | // to be classified const. |
| 124 | HasConst = HasConst || Ty.isConstQualified(); |
| 125 | if (isNonnullType(Ty) && HasConst) |
| 126 | return true; |
| 127 | } else { |
| 128 | return false; |
| 129 | } |
| 130 | } |
| 131 | return false; |
| 132 | } |
| 133 | |
| 134 | /// \return whether @c type is extremely unlikely to be null |
| 135 | bool NonnullGlobalConstantsChecker::isNonnullType(QualType Ty) const { |
| 136 | |
| 137 | if (Ty->isPointerType() && Ty->getPointeeType()->isCharType()) |
| 138 | return true; |
| 139 | |
| 140 | if (auto *T = dyn_cast<ObjCObjectPointerType>(Val&: Ty)) { |
| 141 | return T->getInterfaceDecl() && |
| 142 | T->getInterfaceDecl()->getIdentifier() == NSStringII; |
| 143 | } else if (auto *T = Ty->getAs<TypedefType>()) { |
| 144 | IdentifierInfo* II = T->getDecl()->getIdentifier(); |
| 145 | return II == CFStringRefII || II == CFBooleanRefII || II == CFNullRefII; |
| 146 | } |
| 147 | return false; |
| 148 | } |
| 149 | |
| 150 | void ento::registerNonnullGlobalConstantsChecker(CheckerManager &Mgr) { |
| 151 | Mgr.registerChecker<NonnullGlobalConstantsChecker>(); |
| 152 | } |
| 153 | |
| 154 | bool ento::shouldRegisterNonnullGlobalConstantsChecker(const CheckerManager &mgr) { |
| 155 | return true; |
| 156 | } |
| 157 | |